Re: [PATCH v10 03/26] dt-bindings: ufs: mediatek,ufs: Add mt8196 variant

Hi Krzysztof,

On Fri, 2026-07-31 at 10:27 +0200, Krzysztof Kozlowski wrote:
> On Thu, Jul 30, 2026 at 11:48:59AM +0200, Louis-Alexis Eyraud wrote:
> > =C2=A0
> > =C2=A0examples:
> > =C2=A0=C2=A0 - |
> > @@ -177,3 +192,33 @@ examples:
> > =C2=A0
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mediatek,ufs-disable-m=
cq;
> > =C2=A0=C2=A0=C2=A0=C2=A0 };
> > +=C2=A0 - |
> > +=C2=A0=C2=A0=C2=A0 #include <dt-bindings/reset/mediatek,mt8196-resets.=
h>
> > +=C2=A0=C2=A0=C2=A0 #include <dt-bindings/interrupt-controller/arm-gic.=
h>
> > +
> > +=C2=A0=C2=A0=C2=A0 ufshci@16810000 {
>=20
> You already added second example. That's enough.
>=20
I'll drop it.

> Sashiko reports are valid.
>=20
the reports are indeed right about the missing supply description for
AVDD09_UFS_1 pin.

The MT8196 and MT88894 SoC datasheets do confirm they are different
supplies, so I'll add its description and also its handling in the
driver (in an additional patch) in the next revision.

I'll fix the typo (present since v3) as well.

Best regards,
Louis-Alexis


> Best regards,
> Krzysztof
>=20