Re: [PATCH v3 44/57] scsi: pm8001: Enable lock context analysis

On Fri, Jul 31, 2026 at 12:48=E2=80=AFAM Bart Van Assche <[email protected]=
g> wrote:
>
> Document locking requirements with __must_hold().
>
> Signed-off-by: Bart Van Assche <[email protected]>
Acked-by: Jack Wang <[email protected]>
> ---
>  drivers/scsi/pm8001/Makefile     | 1 +
>  drivers/scsi/pm8001/pm80xx_hwi.c | 2 ++
>  2 files changed, 3 insertions(+)
>
> diff --git a/drivers/scsi/pm8001/Makefile b/drivers/scsi/pm8001/Makefile
> index bbb51b7312f1..b236359810fe 100644
> --- a/drivers/scsi/pm8001/Makefile
> +++ b/drivers/scsi/pm8001/Makefile
> @@ -4,6 +4,7 @@
>  #
>  # Copyright (C) 2008-2009  USI Co., Ltd.
>
> +CONTEXT_ANALYSIS :=3D y
>
>  obj-$(CONFIG_SCSI_PM8001) +=3D pm80xx.o
>
> diff --git a/drivers/scsi/pm8001/pm80xx_hwi.c b/drivers/scsi/pm8001/pm80x=
x_hwi.c
> index 7a348f0194bd..ff6fdb761a70 100644
> --- a/drivers/scsi/pm8001/pm80xx_hwi.c
> +++ b/drivers/scsi/pm8001/pm80xx_hwi.c
> @@ -2294,6 +2294,7 @@ static void mpi_ssp_event(struct pm8001_hba_info *p=
m8001_ha, void *piomb)
>  static void
>  mpi_sata_completion(struct pm8001_hba_info *pm8001_ha,
>                 struct outbound_queue_table *circularQ, void *piomb)
> +       __must_hold(&circularQ->oq_lock)
>  {
>         struct sas_task *t;
>         struct pm8001_ccb_info *ccb;
> @@ -3858,6 +3859,7 @@ static int ssp_coalesced_comp_resp(struct pm8001_hb=
a_info *pm8001_ha,
>   */
>  static void process_one_iomb(struct pm8001_hba_info *pm8001_ha,
>                 struct outbound_queue_table *circularQ, void *piomb)
> +       __must_hold(&circularQ->oq_lock)
>  {
>         __le32 pHeader =3D *(__le32 *)piomb;
>         u32 opc =3D (u32)((le32_to_cpu(pHeader)) & 0xFFF);