Re: [PATCH 1/2] scsi: zfcp: Add __must_hold() attribute to zfcp_qdio_sbal_get()

> Add __must_hold() attribute to zfcp_qdio_sbal_get() in order to let
> clang's context analysis know that qdio->req_q_wq must be held on
> function entry. This is also documented above the function. Without this
> annotation this leads to a valid warning when context analysis is
> enabled:
> 
> drivers/s390/scsi/zfcp_qdio.c:287:8: warning:
>   expecting spinlock '->req_q_lock' to be held at start of each loop [-Wthread-safety-analysis]
>   287 |         ret = wait_event_interruptible_lock_irq_timeout(qdio->req_q_wq,
>       |               ^
> 
> Signed-off-by: Heiko Carstens <[email protected]>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1