Re: [PATCH 2/2] scsi: ibmvfc: document protocol parameter of ibmvfc_alloc_target()

Muhammad Falak R Wani <[email protected]> writes:

> Commit 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> added a protocol parameter to ibmvfc_alloc_target() but did not describe
> it in the function's kernel-doc comment, so a W=1 build warns:
>
>   drivers/scsi/ibmvscsi/ibmvfc-core.c:4996: warning: Function parameter
>   or struct member 'protocol' not described in 'ibmvfc_alloc_target'
>
> Add the missing parameter description.
>
> Fixes: 249313b3f7b5 ("scsi: ibmvfc: allocate targets based on protocol")
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Muhammad Falak R Wani <[email protected]>
> ---
>  drivers/scsi/ibmvscsi/ibmvfc-core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc-core.c b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> index d1956552698e0..6fd4c601f978c 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc-core.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc-core.c
> @@ -4987,6 +4987,7 @@ static void ibmvfc_tgt_query_target(struct ibmvfc_target *tgt)
>   * ibmvfc_alloc_target - Allocate and initialize an ibmvfc target
>   * @vhost:		ibmvfc host struct
>   * @target:		Holds SCSI ID to allocate target forand the WWPN
> + * @protocol:		protocol of the target to allocate
>   *
>   * Returns:
>   *	0 on success / other on failure

Reviewed-by: Dave Marquardt <[email protected]>