Re: [PATCH 01/10] ufs: unipro: Move Tx/Rx FSM state definitions to unipro.h

On 8/27/26 6:59 AM, Larisa Ileana Grigore wrote:
> The reason the two enums currently look duplicated is that they 
> represent the encodings of two distinct MIPI M-PHY attributes, 
> RX_FSM_STATE and TX_FSM_STATE. The specification defines identical state 
> encodings for both RX and TX FSMs, which is why the values are the same.
> 
> My intention was to preserve the original approach and minimize the 
> scope of the changes in this patch. Since the existing code already 
> treats the RX and TX FSM states separately, I kept that structure when 
> moving the definitions to the common header.
> 
> I will clarify in the commit message that these encodings come from the 
> MIPI M-PHY specification and are not DesignWare-specific.

I'm fine with keeping these two enums separate.

Please add a comment above each enum with a reference to the section of
the M-PHY spec these enums come from.

Thanks,

Bart.