Re: [PATCH v1 04/11] dt-bindings: soc: qcom: add binding for qcom,crypto-virt

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding uses a driver-centric title and an underscore in the example node name, which violates device tree conventions.
--

commit 76a2bbd8a4bf8175fb462a6f688e076226259b19
Author: linlzhan <[email protected]>

dt-bindings: soc: qcom: add binding for qcom,crypto-virt

This commit documents the device tree binding for the Qualcomm GVM crypto-virt
node. It provides the wrapped-key buffer size needed by the driver to perform
hardware-wrapped-key SCM operations backing virtio_blk's inline crypto layer.

> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml
> new file mode 100644
> index 0000000000000..5eb204f297627
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,crypto-virt.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/qcom/qcom,crypto-virt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: QCOM GVM Crypto Virt driver

[Severity: Low]
Does this title violate device tree conventions by describing an OS driver
instead of the hardware or firmware interface?

[ ... ]

> +additionalProperties: false
> +
> +examples:
> +  - |
> +    crypto_virt {

[Severity: Low]
Should this example node name use a generic hyphenated name instead of an
underscore?

Using an underscore here propagates styling violations that trigger
'node_name_chars_strict' warnings during DT schema validation.

> +        compatible = "qcom,crypto-virt";
> +        qcom,wrapped-key-size = <100>;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=4