Re: [PATCH v2 008/110] jbd2: use PRIino format for i_ino
Jan Kara <[email protected]>
| Newsgroups | org.kernel.vger.linux-sctp,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <vtdds6ie2xhtkvmlqmhmuuexlllt4c4zvpohuxbwldh5uhdfxt@bq5kjpmviqjf> |
On Mon 02-03-26 15:23:52, Jeff Layton wrote: > Convert jbd2 i_ino format strings to use the PRIino format > macro in preparation for the widening of i_ino via kino_t. > > Also correct signed format specifiers to unsigned, since inode > numbers are unsigned values. > > Signed-off-by: Jeff Layton <[email protected]> Looks good. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/jbd2/journal.c | 4 ++-- > fs/jbd2/transaction.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c > index cb2c529a8f1bea33df6d4135e5782b9a77792732..9df937f0e15c71028038e1c0c12159421a2444b4 100644 > --- a/fs/jbd2/journal.c > +++ b/fs/jbd2/journal.c > @@ -1677,7 +1677,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode) > return err ? ERR_PTR(err) : ERR_PTR(-EINVAL); > } > > - jbd2_debug(1, "JBD2: inode %s/%ld, size %lld, bits %d, blksize %ld\n", > + jbd2_debug(1, "JBD2: inode %s/%" PRIino "u, size %lld, bits %d, blksize %ld\n", > inode->i_sb->s_id, inode->i_ino, (long long) inode->i_size, > inode->i_sb->s_blocksize_bits, inode->i_sb->s_blocksize); > > @@ -1689,7 +1689,7 @@ journal_t *jbd2_journal_init_inode(struct inode *inode) > > journal->j_inode = inode; > snprintf(journal->j_devname, sizeof(journal->j_devname), > - "%pg-%lu", journal->j_dev, journal->j_inode->i_ino); > + "%pg-%" PRIino "u", journal->j_dev, journal->j_inode->i_ino); > strreplace(journal->j_devname, '/', '!'); > jbd2_stats_proc_init(journal); > > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c > index dca4b5d8aaaa3e1505b09fab42eb45bb201a8db8..2a03d4eafdee95e5caa8dbd0afe4e32ef4104378 100644 > --- a/fs/jbd2/transaction.c > +++ b/fs/jbd2/transaction.c > @@ -2651,7 +2651,7 @@ static int jbd2_journal_file_inode(handle_t *handle, struct jbd2_inode *jinode, > return -EROFS; > journal = transaction->t_journal; > > - jbd2_debug(4, "Adding inode %lu, tid:%d\n", jinode->i_vfs_inode->i_ino, > + jbd2_debug(4, "Adding inode %" PRIino "u, tid:%d\n", jinode->i_vfs_inode->i_ino, > transaction->t_tid); > > spin_lock(&journal->j_list_lock); > > -- > 2.53.0 > -- Jan Kara <[email protected]> SUSE Labs, CR