Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro
Christoph Hellwig <[email protected]>
| Newsgroups | org.kernel.vger.linux-sctp,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Mar 03, 2026 at 08:43:15AM -0500, Jeff Layton wrote: > On Tue, 2026-03-03 at 05:37 -0800, Christoph Hellwig wrote: > > On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > > Like I said to Ted, this is just temporary scaffolding for the change. > > > The PRIino macro is removed in the end. Given that, perhaps you can > > > overlook the bikeshed's color in this instance? > > > > So why add it in the first place? > > Bisectability. The first version I did of this would have broken the > ability to bisect properly across these changes. I don't love the > "churn" here either, but this should be cleanly bisectable. What do you need to bisect in format string changes? Splitting every variable type change outside of the main i_ino out - sure. But bisecting that "change to u64 in ext4" really broke ext4 and not "change to u64" is not very useful. Commits should do one well defined thing. Adding a weird transition layer for a format thing that just gets dropped is not one well defined thing.