Re: [PATCH v3 12/12] treewide: change inode->i_ino from unsigned long to u64
Damien Le Moal <[email protected]>
| Newsgroups | org.kernel.vger.linux-sctp,dev.linux.lists.fsverity,dev.linux.lists.netfs,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.ocfs2-devel,dev.linux.lists.v9fs,net.sourceforge.lists.linux-f2fs-devel,org.freedesktop.lists.amd-gfx,org.freedesktop.lists.dri-devel,org.infradead.lists.linux-mtd,org.kernel.vger.audit,org.kernel.vger.autofs,org.kernel.vger.bpf,org.kernel.vger.ceph-devel,org.kernel.vger.ecryptfs,org.kernel.vger.linux-bluetooth,org.kernel.vger.linux-can,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fscrypt,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-hams,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-media,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-security-module,org.kernel.vger.linux-trace-kernel,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-x25,org.kernel.vger.linux-xfs,org.kernel.vger.netdev,org.kernel.vger.selinux,org.kvack.linux-mm |
|---|---|
| Organization | Western Digital Research |
| Message-ID | <[email protected]> |
On 3/5/26 00:32, Jeff Layton wrote: > On 32-bit architectures, unsigned long is only 32 bits wide, which > causes 64-bit inode numbers to be silently truncated. Several > filesystems (NFS, XFS, BTRFS, etc.) can generate inode numbers that > exceed 32 bits, and this truncation can lead to inode number collisions > and other subtle bugs on 32-bit systems. > > Change the type of inode->i_ino from unsigned long to u64 to ensure that > inode numbers are always represented as 64-bit values regardless of > architecture. Update all format specifiers treewide from %lu/%lx to > %llu/%llx to match the new type, along with corresponding local variable > types. > > This is the bulk treewide conversion. Earlier patches in this series > handled trace events separately to allow trace field reordering for > better struct packing on 32-bit. > > Signed-off-by: Jeff Layton <[email protected]> For the zonefs bits: Acked-by: Damien Le Moal <[email protected]> -- Damien Le Moal Western Digital Research