Re: [PATCH net-next v5] sctp: auth: discard auth_chunk when skb_clone fails
Jakub Kicinski <[email protected]> Wed, 29 Jul 2026 16:35:42 -0700
| Newsgroups | org.kernel.vger.linux-sctp,org.kernel.vger.linux-kernel,org.kernel.vger.netdev |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 29 Jul 2026 10:43:26 -0400 Xin Long wrote: > > > When processing AUTH + COOKIE-ECHO packets, if skb_clone() fails > > > due to memory pressure, chunk->auth_chunk is NULL. The original > > > code still sets chunk->auth = 1 and continues, leaving the > > > COOKIE-ECHO to be processed without a valid auth_chunk for > > > deferred verification. > > > > > > Discard the AUTH chunk early via pdiscard when skb_clone() fails, > > > so that the receive loop can continue processing remaining chunks > > > in the inqueue instead of stalling the entire packet. > > > > Hi Xin Long, should we apply this or it's no longer worth it after > > 8e04823c120b ? > > > Apply it to net-next.git. > > Acked-by: Xin Long <[email protected]> Thanks! > So sending patches with wrong in-reply-to doesn't require repost? If patchwork ingests the series correctly (which is usually does for single patch postings) there's no need to resend. It's mostly a convenience thing for maintainers since we try to process patches from oldest and the threading makes the sort harder.