Re: [RFC PATCH 1/4] capabily: Add new capable_noaudit

"Serge E. Hallyn" <[email protected]>
Newsgroups org.kernel.vger.linux-security-module,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs
Message-ID <[email protected]> 
On Mon, Jun 29, 2026 at 02:29:39PM +0200, Christoph Hellwig wrote:
> On Fri, Jun 26, 2026 at 01:45:20PM +0200, [email protected] wrote:
> > +extern bool capable_noaudit(int cap);
> 
> No need for the extern.
> 
> Otherwise this does look nice an clean to me:
> 
> Reviewed-by: Christoph Hellwig <[email protected]>
> 
> But if the security folks don't like we can live with the more
> verbose version of it I guess.

Honestly I'm ok either way.  If people misunderstand the shortcut,
and ove-ruse it, that's safer than the other way.  The one that
scare me more is ns_capable(&current_user_ns, X).  I need to do an
audit of the current users of that.

So I'm happy to put

Reviewed-by: Serge Hallyn <[email protected]>

on the set.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.