Re: [PATCH v6 bpf-next 3/4] bpf: add bpf_init_inode_xattr kfunc for atomic inode labeling
"Kumar Kartikeya Dwivedi" <[email protected]> Sat, 01 Aug 2026 00:04:34 +0200
| Newsgroups | org.kernel.vger.linux-security-module,org.kernel.vger.bpf,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel,org.kernel.vger.linux-kselftest,org.kernel.vger.selinux |
|---|---|
| Message-ID | <[email protected]> |
On Fri Jul 31, 2026 at 11:49 PM CEST, Paul Moore wrote: > On Fri, Jul 31, 2026 at 5:29=E2=80=AFPM Kumar Kartikeya Dwivedi > <[email protected]> wrote: >> On Fri Jul 31, 2026 at 10:48 PM CEST, Paul Moore wrote: >> > On Fri, Jul 31, 2026 at 4:16=E2=80=AFPM Kumar Kartikeya Dwivedi >> > <[email protected]> wrote: >> >> On Fri Jul 31, 2026 at 10:01 PM CEST, Paul Moore wrote: >> >> > On Fri, Jul 31, 2026 at 3:20=E2=80=AFPM Kumar Kartikeya Dwivedi >> >> > <[email protected]> wrote: >> >> >> On Fri Jul 31, 2026 at 9:05 PM CEST, Paul Moore wrote: >> >> >> > On Fri, Jul 31, 2026 at 2:50=E2=80=AFPM Kumar Kartikeya Dwivedi >> >> >> > <[email protected]> wrote: >> >> >> >> On Fri Jul 31, 2026 at 8:42 PM CEST, Paul Moore wrote: >> >> >> >> > On Fri, Jul 31, 2026 at 2:18=E2=80=AFPM Kumar Kartikeya Dwive= di >> >> >> >> > <[email protected]> wrote: >> >> >> >> >> On Fri Jul 31, 2026 at 6:59 PM CEST, Paul Moore wrote: >> >> >> >> >> > On Fri, Jul 31, 2026 at 12:32=E2=80=AFPM Kumar Kartikeya D= wivedi >> >> >> >> >> > <[email protected]> wrote: >> >> >> >> >> >> On Fri Jul 31, 2026 at 6:02 PM CEST, Paul Moore wrote: >> >> >> >> >> >> > On Fri, Jul 31, 2026 at 11:44=E2=80=AFAM Kumar Kartikey= a Dwivedi >> >> >> >> >> >> > <[email protected]> wrote: >> >> >> >> >> >> >> On Fri Jul 31, 2026 at 5:30 PM CEST, David Windsor wro= te: >> >> >> >> >> >> >> > On Fri, Jul 31, 2026 at 11:17=E2=80=AFAM Paul Moore = <[email protected]> wrote: > > ... > >> I think you keep forgetting that you cannot unilaterally decide this. Bo= th VFS >> and BPF people have told you that it does not make sense. What was clear= ly LSM >> specific code has been moved under security/ already. > > I'm charged with doing the Right Thing for the LSM framework, and in > my opinion it is in the best interest of the LSM framework that the > kfunc being proposed lives in security/bpf_lsm_kfuncs.c, just as the > VFS kfuncs live in fs/bpf_fs_kfuncs.c. > I think the "Right Thing" would be caring about your users and the project moving forward, who want this functionality, and figuring out the best way = to make it happen while working collaboratively with others. Life is full of tradeoffs. Instead of dictating how others should bend over backwards to agree to your arbitrary rules on code organization, which they don't agree with. Everyone you've pitched your idea on code organization to disagrees with yo= u. Yet, you remain adamant that it's the only way forward. Materially, both you and I know nothing of consequence would happen if the = kfunc stays where it is. As a consequence, everyone suffers because they first need to satisfy your = whims on how all code and kfuncs written thus far are wrong, and need to be moved around ASAP, including the one being proposed. Not only is that a disservice to your users, but also people who've reviewe= d code (apart from you), and more importantly the person who worked on this p= atch set for several months. At least a month ago, you had the good sense of not dying over this hill. > [...]