[PATCH] ima: clean up IMA_MEASURE_PCR_IDX in Kconfig

Julian Braha <[email protected]>
Newsgroups org.kernel.vger.linux-security-module,org.kernel.vger.linux-integrity,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
The IMA_MEASURE_PCR_IDX option is not visible for users to set, so it
always uses its default, 10. This means that the 'range 8 14' is dead
code, and the "If unsure, use the default 10" in the help text is
misleading because the user *has no other choice*.

During the first patch submission to add this option in 2008 [1],
the submitter originally gave this option a prompt:

"PCR for Aggregate (8 <= Index <= 14)"

then later removed it in the revision, without adjusting the rest of the
option accordingly [2].

Let's clean up this of this IMA_MEASURE_PCR_IDX config option to be
consistent with its current, non-visible state.

This dead range was found by kconfirm, a static analysis tool for Kconfig.

Signed-off-by: Julian Braha <[email protected]>
---
 security/integrity/ima/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
index b3a9f86809b0..8a67bc1faa4c 100644
--- a/security/integrity/ima/Kconfig
+++ b/security/integrity/ima/Kconfig
@@ -46,12 +46,11 @@ config IMA_KEXEC
 
 config IMA_MEASURE_PCR_IDX
 	int
-	range 8 14
 	default 10
 	help
 	  IMA_MEASURE_PCR_IDX determines the TPM PCR register index
 	  that IMA uses to maintain the integrity aggregate of the
-	  measurement list.  If unsure, use the default 10.
+	  measurement list.
 
 config IMA_LSM_RULES
 	bool
-- 
2.55.0
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.