Re: [PATCH 2/4] serial: 8250: export serial8250_get_baud_rate()

On Thu, Jul 09, 2026 at 11:39:32PM +0200, Christian Marangi wrote:
> On Fri, Jul 10, 2026 at 12:35:02AM +0300, Andy Shevchenko wrote:
> > On Thu, Jul 09, 2026 at 10:56:50PM +0200, Christian Marangi wrote:
> > > Some driver might need to access the current baud rate to correctly
> > > configure it.
> > > 
> > > Export the serial8250_get_baud_rate() function to limit code duplication.
> > 
> > Why?
> > 
> > We have _get_divisor() / _set_divisor() for exactly that purpose, no?
> 
> I can only see set and I'm not following how that helps with any driver
> that needs to get the baud_rate?

You operate on the divisor settings instead of baud rate. Otherwise, can
you elaborate why no other (out of dozens!) driver needs this? What do
you try to achieve with the baud rate settings exactly?

-- 
With Best Regards,
Andy Shevchenko