Re: [PATCHv3 0/6] serial: mxs-auart: devm conversion, clock rework, and IRQ ordering fixes
Greg Kroah-Hartman <[email protected]>
| Newsgroups | org.kernel.vger.linux-serial,dev.linux.lists.imx,org.infradead.lists.linux-arm-kernel,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026071011-geiger-smugly-4069@gregkh> |
On Wed, Jun 10, 2026 at 08:38:50PM -0700, Rosen Penev wrote: > This series cleans up the mxs-auart driver by converting to devm-managed > resources, fixing clock prepare/enable ordering, and addressing IRQ > registration races. > > Patch 1 fixes compilation on 64-bit build with W=1 > > Patch 2 reworks the clock handling to use devm_clk_get_enabled and > reorders clk_prepare_enable after clk_set_rate to avoid > CLK_SET_RATE_GATE failures. > > Patch 3 converts iomem mapping and GPIO IRQ requests to devm, > removing the manual cleanup paths. > > Patch 4 moves the main UART IRQ registration after uart_add_one_port > so the port state is initialized before the handler can run, and > manages the module clock for console vs non-console ports correctly. Do you have this hardware to test this with? If not, I would just leave this alone as devm_* conversions are tricky and prone to bugs. thanks, greg k-h