Re: [PATCH] serial: 8250_hub6: add missing include for hub6_match_port()

Hi Greg,

On Wed, 15 Jul 2026 07:16:46 +0200
Greg Kroah-Hartman <[email protected]> wrote:

> On Wed, Jul 15, 2026 at 07:42:00AM +0800, kernel test robot wrote:
> > Hi Hugo,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on c1d4ce2d9eaeccd7e8aef7ec1109df49eaf4f503]
> > 
> > url:    https://github.com/intel-lab-lkp/linux/commits/Hugo-Villeneuve/serial-8250_hub6-add-missing-include-for-hub6_match_port/20260714-092814
> > base:   c1d4ce2d9eaeccd7e8aef7ec1109df49eaf4f503
> > patch link:    https://lore.kernel.org/r/20260714012610.576746-1-hugo%40hugovil.com
> > patch subject: [PATCH] serial: 8250_hub6: add missing include for hub6_match_port()
> > config: parisc-allmodconfig (https://download.01.org/0day-ci/archive/20260715/[email protected]/config)
> > compiler: hppa-linux-gcc (GCC) 16.1.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260715/[email protected]/reproduce)
> > 
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <[email protected]>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > 
> > All errors (new ones prefixed by >>):
> > 
> > >> drivers/tty/serial/8250/8250_hub6.c:46:6: error: redefinition of 'hub6_match_port'
> >       46 | bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> >          |      ^~~~~~~~~~~~~~~
> >    In file included from drivers/tty/serial/8250/8250_hub6.c:10:
> >    drivers/tty/serial/8250/8250.h:340:20: note: previous definition of 'hub6_match_port' with type 'bool(const struct uart_port *, const struct uart_port *)' {aka '_Bool(const struct uart_port *, const struct uart_port *)'}
> >      340 | static inline bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> >          |                    ^~~~~~~~~~~~~~~
> > 
> > 
> > vim +/hub6_match_port +46 drivers/tty/serial/8250/8250_hub6.c
> > 
> > ec9f47cd6a14ca drivers/serial/8250_hub6.c          Russell King    2005-06-27  45  
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21 @46  bool hub6_match_port(const struct uart_port *port1, const struct uart_port *port2)
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21  47  {
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21  48  	return port1->iobase == port2->iobase && port1->hub6 == port2->hub6;
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21  49  }
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21  50  EXPORT_SYMBOL_GPL(hub6_match_port);
> > 3d406299d88297 drivers/tty/serial/8250/8250_hub6.c Hugo Villeneuve 2026-05-21  51  
> 
> This patch didn't cause this problem, just made it show up.  Can you
> provide a follow-on patch that fixes this?

I'm on it

-- 
Hugo Villeneuve