Re: [PATCH] Revert "serial: 8250: Clear CON_PRINTBUFFER on port re-registration"

John Ogness <[email protected]> Fri, 24 Jul 2026 10:38:02 +0206
Newsgroups org.kernel.vger.linux-serial,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On 2026-07-24, Fushuai Wang <[email protected]> wrote:
> From: Fushuai Wang <[email protected]>
>
> This reverts commit d338ab1d90603f875c4f7ed223406535378173a5.
>
> This may cause some boot logs to be lost on some platforms.
>
> Reported-by: Mark Brown <[email protected]>
> Reported-by: Anirudh Srinivasan <[email protected]>
> Link: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Fushuai Wang <[email protected]>

Reviewed-by: John Ogness <[email protected]>

I also recently stumbled on commmit d338ab1d9060 ("serial: 8250: Clear
CON_PRINTBUFFER on port re-registration") and was surprised to see it
was accepted.

If the double-printing is happening for certain cases with 8250_pnp, I
would expect 8250_pnp (not 8250_core) to detect and handle that
case. 8250_core is the base for a lot of 8250 variants.

John Ogness