Re: [PATCH] serial: sc16is7xx: implement gpio get_direction() callback

Linus Walleij <[email protected]> Sat, 25 Jul 2026 00:09:53 +0200
Newsgroups org.kernel.vger.linux-serial,org.kernel.vger.linux-gpio,org.kernel.vger.linux-kernel
Message-ID <CAD++jLnzMEL5vauna86RgLWs1edcvE4YEddoBEZN9Gkc8XQzzw@mail.gmail.com>
On Thu, Jul 16, 2026 at 11:08 PM Hugo Villeneuve <[email protected]> wrote:

> From: Hugo Villeneuve <[email protected]>
>
> It's strongly recommended for GPIO drivers to always implement the
> .get_direction() callback - even when the direction is tracked in
> software. The GPIO core emits a warning when the callback is missing
> and a user reads the direction of a line, e.g. via
> /sys/kernel/debug/gpio.
>
> Fixes: dfeae619d781 ("serial: sc16is7xx")
> Cc: [email protected]
> Signed-off-by: Hugo Villeneuve <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij