Re: [PATCH] tty: moxa: remove driver.
Greg Kroah-Hartman <[email protected]> Tue, 4 Aug 2026 15:31:41 +0200
| Newsgroups | org.kernel.vger.linux-serial,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <2026080434-bundle-syrup-582d@gregkh> |
On Tue, Aug 04, 2026 at 12:19:40PM +0200, Jiri Slaby wrote: > On 04. 08. 26, 12:18, Jiri Slaby wrote: > > On 04. 08. 26, 11:57, Greg Kroah-Hartman wrote: > > > On Tue, Aug 04, 2026 at 07:12:01AM +0200, Jiri Slaby wrote: > > > > On 03. 08. 26, 14:52, Greg Kroah-Hartman wrote: > > > > > This is a very old driver, and no known hardware is still > > > > > around for it, > > > > > and the company says they do not need it anymore, so let's remove it as > > > > > the LLMs are starting to poke at it and find "interesting" things which > > > > > will just waste everyone's time given it's not actually used. > > > > > > > > > > So let's drop it. If someone really needs it, it can come back in the > > > > > future, in a more "modern" way, as the style here is very old... > > > > > > > > > > Reported-by: Jiri Slaby <[email protected]> > > > > > Cc: Crescent Hsieh <[email protected]> > > > > > Link: > > > > > https://lore.kernel.org/all/afqyY8FQ8ZfpH48_@moxa-ThinkCentre- > > > > > M90t/ > > > > > Signed-off-by: Greg Kroah-Hartman <[email protected]> > > > > > > > > LGTM, there are leftovers though: > > > > MAINTAINERS > > > > 18341:MOXA SMARTIO/INDUSTIO/INTELLIO SERIAL CARD > > > > > > As you said, that one documents the mxser.c file, not moxa.c, so should > > > I just remove both and this entry too? > > > > > > And the .rst file needs to go, right? > > > > SMARTIO/INDUSTIO = mxser is supposed to stay. > > INTELLIO = moxa is being removed. > > That being said, the "/INTELLIO" part should go. Great, will do that, thanks! greg k-h