Re: [PATCH 1/2] tty: moxa: unwind tty driver if PCI registration fails

Hi Jiri and Greg,

Thanks for the review. I agree that removing the whole MOXA driver is
the better direction, which supersedes this patch. Please drop/ignore
this patch.

Best regards,
Myeonghun

2026=EB=85=84 8=EC=9B=94 3=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 9:41, Gr=
eg Kroah-Hartman <[email protected]>=EB=8B=98=EC=9D=B4 =EC=9E=91=
=EC=84=B1:
>
> On Mon, Aug 03, 2026 at 08:06:58AM +0200, Jiri Slaby wrote:
> > On 31. 07. 26, 18:18, Myeonghun Pak wrote:
> > > moxa_init() registers the tty driver before registering the PCI drive=
r.
> > > If pci_register_driver() fails, module initialization returns without
> > > unregistering the tty driver or dropping its reference. moxa_exit() i=
s
> > > not called after a failed module initialization.
> > >
> > > Unregister the tty driver and drop its reference before returning the
> > > PCI registration error.
> > I think, we should remove the whole driver instead:
> > https://lore.kernel.org/all/2da84e36-7ac6-407d-8e08-edca82f4cbce@kernel=
.org/
>
> I agree, I'll submit a patch to just drop it.
>
> thanks,
>
> greg k-h