Re: [PATCH v2 1/8] serial: txx9: Drop noop probe function and dangerous remove callback

On Tue, 4 Aug 2026 at 15:52, Atsushi Nemoto <[email protected]> wrote:
> On Tue,  4 Aug 2026 10:57:53 +0200, Uwe Kleine-K=C3=B6nig (The Capable Hu=
b) <[email protected]> wrote:
> > The only platform device that can be bound to the driver is allocated b=
y
> > the driver itself. That device doesn't have platdata, so the probe
> > function only consists of a loop that is never run and thus can be
> > dropped without loss of functionality.
>
> The noop loop might came from old 8250 driver I referenced at that time.
> Now I think it can be removed safely.
> Thank you for this cleanup.
>
> Reviewed-by: Atsushi Nemoto <[email protected]>

TX4927 actually has two serial ports:

    $ cat proc/iomem
    [...]
    fff1f0000-fff1fffff : TX4927
      [...]
      fff1ff300-fff1ff323 : serial_txx9
      fff1ff400-fff1ff423 : serial_txx9

At first sight, I don't see how these are registered, but it still works
after your patch, so
Tested-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
.org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds