Re: [PATCH v4 1/2] dt-bindings: serial: 8250: Add Airoha compatibles

On Mon, Aug 10, 2026 at 10:02:21AM -0500, Rob Herring wrote:
> On Sun, Aug 09, 2026 at 02:14:46PM +0200, Christian Marangi wrote:
> > From: Benjamin Larsson <[email protected]>
> > 
> > The Airoha SoC family have a mostly 16550-compatible UART
> > and High-Speed UART hardware with the exception of custom
> > baud rate settings register.
> > 
> > Signed-off-by: Benjamin Larsson <[email protected]>
> > Signed-off-by: Christian Marangi <[email protected]>
> > Acked-by: Conor Dooley <[email protected]>
> > ---
> >  Documentation/devicetree/bindings/serial/8250.yaml | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/8250.yaml b/Documentation/devicetree/bindings/serial/8250.yaml
> > index bb7b9c87a807..b6f7e093d8d7 100644
> > --- a/Documentation/devicetree/bindings/serial/8250.yaml
> > +++ b/Documentation/devicetree/bindings/serial/8250.yaml
> > @@ -110,6 +110,11 @@ properties:
> >        - const: mrvl,pxa-uart
> >        - const: nuvoton,wpcm450-uart
> >        - const: nuvoton,npcm750-uart
> > +      - const: airoha,en7523-uart
> > +      - items:
> > +          - const: airoha,an7581-uart
> > +          - const: airoha,en7523-uart
> 
> Don't stick this in the middle of a bunch single entry items (which 
> should really be an 'enum' if you would like to clean that up).
>

Let me see what I can do... Seems this schema really needs some love.
 
> > +      - const: airoha,an7581-hsuart
> >        - const: nvidia,tegra20-uart
> >        - const: nxp,lpc3220-uart
> 
> >        - items:
> > -- 
> > 2.53.0
> > 

-- 
	Ansuel