Re: [PATCH 3/3] serial: 8250_mxpcie: take the line settings from the new termios
Crescent Hsieh <[email protected]>
| Newsgroups | org.kernel.vger.linux-serial,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <aoZk9e3-0UHLGpSB@moxa-KabyLake-H> |
On Wed, Aug 19, 2026 at 08:15:48PM +0800, Linmao Li wrote:
> 在 2026/8/19 18:00, Crescent Hsieh 写道:
> > On Tue, Aug 18, 2026 at 05:39:18PM +0800, Linmao Li wrote:
> > > mxpcie8250_set_termios() reads the line settings out of
> > > port->state->port.tty, which is only set once the port has been opened.
> > >
> > > uart_set_options() builds a termios of its own and calls ->set_termios()
> > > with no tty behind it, so using such a board as the console
> > > (console=ttyS<n>) dereferences a NULL tty during console setup, as does
> > > attaching kgdboc to it and resuming a suspended console from
> > > uart_resume_port().
> > >
> > > Read the settings from the termios the serial core passes in instead.
> > > It holds the same values on the normal path - uart_change_line_settings()
> > > passes &tty->termios - and it is what serial8250_do_set_termios() right
> > > above already uses.
> > >
> > > Fixes: 55edf8511f47 ("serial: 8250_mxpcie: enable automatic RTS/CTS flow control")
> > > Signed-off-by: Linmao Li <[email protected]>
> > Hi,
> >
> > I tested this by configuring kgdboc on a CP-168EL-A. Thanks for the fix.
>
> Thank you for testing it. May I add your Tested-by to v2?
Yes, please add:
Tested-by: Crescent Hsieh <[email protected]>
---
Thanks,
Crescent Hsieh