Re: [PATCH] m68k: nfcon: don't call console_is_registered in nfcon_device
John Ogness <[email protected]>
| Newsgroups | org.kernel.vger.linux-serial,org.kernel.vger.linux-m68k |
|---|---|
| Message-ID | <[email protected]> |
On 2026-08-17, Geert Uytterhoeven <[email protected]> wrote: > On Sat, 15 Aug 2026 at 09:33, Andreas Schwab <[email protected]> wrote: >> Since 7c2af0f634f1 ("tty: tty_io: use console_list_lock for list >> synchronization") show_cons_active calls the device method under the >> console_list_lock, but console_is_registered tries to acquire >> console_list_lock as well, causing a deadlock. It should not be necessary >> to check console_is_registered here since the function should not be >> called in the fist place when the console is not registered. > > Nice catch! > >> Fixes: 7c2af0f634f1 ("tty: tty_io: use console_list_lock for list synchronization") >> Signed-off-by: Andreas Schwab <[email protected]> > > Reviewed-by: Geert Uytterhoeven <[email protected]> FWIW: Reviewed-by: John Ogness <[email protected]>