Re: [PATCH RESEND 08/12] mm: update all remaining mmap_prepare users to use vma_flags_t

Lorenzo Stoakes <[email protected]>
Newsgroups org.kernel.vger.linux-sgx,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.kernel.vger.keyrings,org.kernel.vger.linux-cxl,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-security-module,org.kernel.vger.linux-xfs,org.kvack.linux-mm,org.ozlabs.lists.linux-erofs
Message-ID <[email protected]>
On Tue, Jan 20, 2026 at 09:01:04AM +0000, Lorenzo Stoakes wrote:
> On Mon, Jan 19, 2026 at 09:59:51PM -0500, Zi Yan wrote:
> > On 19 Jan 2026, at 16:19, Lorenzo Stoakes wrote:
> >
> > > We will be shortly removing the vm_flags_t field from vm_area_desc so we
> > > need to update all mmap_prepare users to only use the dessc->vma_flags
> > > field.
> > >
> > > This patch achieves that and makes all ancillary changes required to make
> > > this possible.
> > >
> > > This lays the groundwork for future work to eliminate the use of vm_flags_t
> > > in vm_area_desc altogether and more broadly throughout the kernel.
> > >
> > > While we're here, we take the opportunity to replace VM_REMAP_FLAGS with
> > > VMA_REMAP_FLAGS, the vma_flags_t equivalent.
> > >
> > > No functional changes intended.
> > >
> > > Signed-off-by: Lorenzo Stoakes <[email protected]>
> > > ---
> > >  drivers/char/mem.c       |  6 +++---
> > >  drivers/dax/device.c     | 10 +++++-----
> > >  fs/aio.c                 |  2 +-
> > >  fs/erofs/data.c          |  5 +++--
> > >  fs/ext4/file.c           |  4 ++--
> > >  fs/ntfs3/file.c          |  2 +-
> > >  fs/orangefs/file.c       |  4 ++--
> > >  fs/ramfs/file-nommu.c    |  2 +-
> > >  fs/resctrl/pseudo_lock.c |  2 +-
> > >  fs/romfs/mmap-nommu.c    |  2 +-
> > >  fs/xfs/xfs_file.c        |  4 ++--
> > >  fs/zonefs/file.c         |  3 ++-
> > >  include/linux/dax.h      |  4 ++--
> > >  include/linux/mm.h       | 24 +++++++++++++++++++-----
> > >  kernel/relay.c           |  2 +-
> > >  mm/memory.c              | 17 ++++++++---------
> > >  16 files changed, 54 insertions(+), 39 deletions(-)
> > >
> >
> > You missed one instance in !CONFIG_DAX:
>
> Yup of course I did... :/ the amount of testing I did here and yet there's
> always some straggler that even allmodconfig somehow doesn't expose.
>
> Let me gather up the cases first and I'll fix-patch.

BTW this is turning into a respin I'll send shortly :) as addressing other
feeedback and removing sparse makes fix-patches not viable unfortunately!

Cheers, Lorenzo
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.