Re: [PATCH v2 08/13] mm: update shmem_[kernel]_file_*() functions to use vma_flags_t
"Darrick J. Wong" <[email protected]>
| Newsgroups | org.kernel.vger.linux-sgx,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.kernel.vger.keyrings,org.kernel.vger.linux-cxl,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-security-module,org.kernel.vger.linux-xfs,org.kvack.linux-mm,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <20260123074652.GW5945@frogsfrogsfrogs> |
On Thu, Jan 22, 2026 at 04:06:17PM +0000, Lorenzo Stoakes wrote: > In order to be able to use only vma_flags_t in vm_area_desc we must adjust > shmem file setup functions to operate in terms of vma_flags_t rather than > vm_flags_t. > > This patch makes this change and updates all callers to use the new > functions. > > No functional changes intended. > > Signed-off-by: Lorenzo Stoakes <[email protected]> > --- > arch/x86/kernel/cpu/sgx/ioctl.c | 2 +- > drivers/gpu/drm/drm_gem.c | 5 +- > drivers/gpu/drm/i915/gem/i915_gem_shmem.c | 2 +- > drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 +- > drivers/gpu/drm/i915/gt/shmem_utils.c | 3 +- > drivers/gpu/drm/ttm/tests/ttm_tt_test.c | 2 +- > drivers/gpu/drm/ttm/ttm_backup.c | 3 +- > drivers/gpu/drm/ttm/ttm_tt.c | 2 +- > fs/xfs/scrub/xfile.c | 3 +- > fs/xfs/xfs_buf_mem.c | 2 +- > include/linux/shmem_fs.h | 8 ++- > ipc/shm.c | 6 +-- > mm/memfd.c | 2 +- > mm/memfd_luo.c | 2 +- > mm/shmem.c | 59 +++++++++++++---------- > security/keys/big_key.c | 2 +- > 16 files changed, 57 insertions(+), 49 deletions(-) > <snip to xfs> > diff --git a/fs/xfs/scrub/xfile.c b/fs/xfs/scrub/xfile.c > index c753c79df203..fe0584a39f16 100644 > --- a/fs/xfs/scrub/xfile.c > +++ b/fs/xfs/scrub/xfile.c > @@ -61,7 +61,8 @@ xfile_create( > if (!xf) > return -ENOMEM; > > - xf->file = shmem_kernel_file_setup(description, isize, VM_NORESERVE); > + xf->file = shmem_kernel_file_setup(description, isize, > + mk_vma_flags(VMA_NORESERVE_BIT)); Seems fine, macro sorcery aside... > if (IS_ERR(xf->file)) { > error = PTR_ERR(xf->file); > goto out_xfile; > diff --git a/fs/xfs/xfs_buf_mem.c b/fs/xfs/xfs_buf_mem.c > index dcbfa274e06d..fd6f0a5bc0ea 100644 > --- a/fs/xfs/xfs_buf_mem.c > +++ b/fs/xfs/xfs_buf_mem.c > @@ -62,7 +62,7 @@ xmbuf_alloc( > if (!btp) > return -ENOMEM; > > - file = shmem_kernel_file_setup(descr, 0, 0); > + file = shmem_kernel_file_setup(descr, 0, EMPTY_VMA_FLAGS); ...but does mk_vma_flags() produce the same result? --D > if (IS_ERR(file)) { > error = PTR_ERR(file); > goto out_free_btp;