Re: [PATCH v2] x86/sgx: use vm_flags_t for vm_prot_bits
"Huang, Kai" <[email protected]>
| Newsgroups | org.kernel.vger.linux-sgx,org.kernel.vger.linux-kernel,org.kvack.linux-mm |
|---|---|
| Message-ID | <[email protected]> |
> > With vm_flags_t I think "theoretically" it could stop being integer type > > someday. But I guess the advantage is when someone does that that can > > trigger build error here (so that we can be aware) which perhaps isn't a > > bad thing? > You're right, the build error would be a useful early warning if > vm_flags_t ever becomes incompatible. > Agreed. It's what type safety means IMHO. > I'm fine either way, let me know > if you'd prefer keeping > unsigned long and I'll send a v3. It's up to maintainer(s), but v2 makes sense to me, so: Acked-by: Kai Huang <[email protected]>