Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single()
Alice Ryhl <[email protected]> Sat, 28 Feb 2026 12:38:48 +0000
| Newsgroups | org.kernel.vger.linux-sgx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.kernel.vger.bpf,org.kernel.vger.kvm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-rdma,org.kernel.vger.linux-s390,org.kernel.vger.netdev,org.kernel.vger.rust-for-linux,org.kvack.linux-mm,org.ozlabs.lists.linuxppc-dev |
|---|---|
| Message-ID | <[email protected]> |
On Fri, Feb 27, 2026 at 09:08:33PM +0100, David Hildenbrand (Arm) wrote: > Nobody except memory.c should really set that parameter to non-NULL. So > let's just drop it and make unmap_mapping_range_vma() use > zap_page_range_single_batched() instead. > > Signed-off-by: David Hildenbrand (Arm) <[email protected]> > diff --git a/rust/kernel/mm/virt.rs b/rust/kernel/mm/virt.rs > index da21d65ccd20..b8e59e4420f3 100644 > --- a/rust/kernel/mm/virt.rs > +++ b/rust/kernel/mm/virt.rs > @@ -124,7 +124,7 @@ pub fn zap_page_range_single(&self, address: usize, size: usize) { > // sufficient for this method call. This method has no requirements on the vma flags. The > // address range is checked to be within the vma. > unsafe { > - bindings::zap_page_range_single(self.as_ptr(), address, size, core::ptr::null_mut()) > + bindings::zap_page_range_single(self.as_ptr(), address, size) > }; Please run rustfmt on Rust changes. Here, rustfmt leads to this being formatted on a single line: unsafe { bindings::zap_page_range_single(self.as_ptr(), address, size) }; with the above changed: Acked-by: Alice Ryhl <[email protected]> # Rust and Binder Alice