Re: [PATCH v1 04/16] mm/memory: simplify calculation in unmap_mapping_range_tree()

"David Hildenbrand (Arm)" <[email protected]> Wed, 11 Mar 2026 09:09:38 +0100
Newsgroups org.kernel.vger.linux-sgx,org.freedesktop.lists.dri-devel,org.freedesktop.lists.intel-gfx,org.kernel.vger.bpf,org.kernel.vger.kvm,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-perf-users,org.kernel.vger.linux-rdma,org.kernel.vger.linux-s390,org.kernel.vger.netdev,org.kernel.vger.rust-for-linux,org.kvack.linux-mm,org.ozlabs.lists.linuxppc-dev
Message-ID <[email protected]>
> 
>> -		start = ((zba - vba) << PAGE_SHIFT) + vma->vm_start;
>> -		size = (zea - zba + 1) << PAGE_SHIFT;
>> +		const pgoff_t start_idx = max(first_index, vma->vm_pgoff);
>> +		const pgoff_t end_idx = min(last_index, vma_last_pgoff(vma)) + 1;
> 
> I guess since 'end' is by-convention the +1 of last this is fine

Exactly, the calculation itself is not changed.

The +1 was previously hiding inside the "(zea - zba + 1)"

Thanks!

-- 
Cheers,

David