Re: [PATCH v2 33/33] tools/testing/vma: output compared expression on ASSERT_[EQ, NE]()

Gregory Price <[email protected]> Fri, 10 Jul 2026 17:09:54 -0400
Newsgroups org.kernel.vger.linux-sgx,dev.linux.lists.iommu,org.freedesktop.lists.dri-devel,org.kernel.vger.kvm,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel,org.kernel.vger.linux-tegra,org.kvack.linux-mm
Message-ID <alFfopehgN0dkMzM@gourry-fedora-PF4VCD3F>
On Fri, Jul 10, 2026 at 09:17:14PM +0100, Lorenzo Stoakes wrote:
> Update the macros to output the compared values at hex for easier debugging
> when test asserts fail.
> 
> We have to be careful not to re-evaluate expressions as they may have
> side-effects. So update the code to take local copies and use these for
> both the test and the debug output.

Aw you found it before i reported it :]

> 
> Also remove unused IS_SET() macro.
> 
> Signed-off-by: Lorenzo Stoakes <[email protected]>


Reviewed-by: Gregory Price <[email protected]>