Re: [PATCH] sh: mm: Remove checks for nonexistent CONFIG_CPU_SUBTYPE_ST40
Geert Uytterhoeven <[email protected]> Mon, 15 Jun 2026 14:11:27 +0200
| Newsgroups | org.kernel.vger.linux-sh |
|---|---|
| Message-ID | <CAMuHMdVhY3iMDsTt=ab+aXmqKm6ZCzBvHYBNO6bFK+rxiEKt1w@mail.gmail.com> |
Hi Ethan, Thanks for your patch! On Sat, 13 Jun 2026 at 23:05, Ethan Nelson-Moore <[email protected]> wrote: > The CONFIG_CPU_SUBTYPE_ST40 option was removed in commit f96691872439 > ("sh: Kill off the remaining ST40 cruft."), but a check for it remained s/remained/was added later/ The ST40-removal predates commit d02b08f6e8b184ff ("sh: Clean up places that make 29-bit physical assumptions."), which introduced the check. > in arch/sh/include/cpu-sh4/cpu/mmu_context.h. Remove this dead code. > Also remove the definition of and references to the MMUCR_SE bit mask, > because it is defined as zero on all CPUs other than ST40. > > Discovered while searching for CONFIG_* symbols referenced in code but > not defined in any Kconfig file. > > Signed-off-by: Ethan Nelson-Moore <[email protected]> Reviewed-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds