Re: [PATCH] sh: Use generic OHCI platform provider symbol

Geert Uytterhoeven <[email protected]> Wed, 24 Jun 2026 20:16:16 +0200
Newsgroups org.kernel.vger.linux-sh,org.kernel.vger.linux-kernel
Message-ID <CAMuHMdVkL629ps2mmD3XRXM-BYWXZ-6GQGM7tKf6vEvhK--LBg@mail.gmail.com>
On Wed, 24 Jun 2026 at 19:56, Pengpeng Hou <[email protected]> wrote:
> The old SuperH-specific `USB_OHCI_SH` provider symbol no longer carries
> an OHCI provider object.  The current platform OHCI provider is
> `USB_OHCI_HCD_PLATFORM`, which builds ohci-platform.o.
>
> Several SH CPU subtypes still select `USB_OHCI_SH`, and the
> sh7757lcr defconfig still enables it directly.  Switch both the subtype
> selects and the defconfig to `USB_OHCI_HCD_PLATFORM` so the intended OHCI
> provider remains reachable when `USB_OHCI_HCD` is enabled.
>
> Signed-off-by: Pengpeng Hou <[email protected]>

Fixes: 4f6dfc2136fb2e8d ("usb: remove the dead USB_OHCI_SH option")
Reviewed-by: Geert Uytterhoeven <[email protected]>

It's a pity people sometimes don't take into account review comments
before applying patches...
https://lore.kernel.org/CAMuHMdVM3BpvVD3c4gp1OidnwF5zFd4MJecij7zWBnahzNaSNw@mail.gmail.com/

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds