Re: [PATCH 5/6] [v5] leds: gpio: make legacy gpiolib interface optional
"Arnd Bergmann" <[email protected]> Mon, 29 Jun 2026 17:58:29 +0200
| Newsgroups | org.kernel.vger.linux-sh,org.kernel.vger.linux-gpio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 29, 2026, at 17:09, Andy Shevchenko wrote:
> On Mon, Jun 29, 2026 at 03:03:28PM +0200, Arnd Bergmann wrote:
>
>> gpiod = devm_gpiod_get_index_optional(dev, NULL, idx, GPIOD_OUT_LOW);
>> - if (IS_ERR(gpiod))
>> - return gpiod;
>
> We can leave these and rather have
>
> gpiod_set_consumer_name(gpiod, template->name);
> return gpiod;
>
> than introduce irregular pattern.
>
Ok, changed now.
Arnd