Re: [PATCH 3/6] [v6] leds: gpio: make legacy gpiolib interface optional
Lee Jones <[email protected]> Thu, 23 Jul 2026 12:40:45 +0100
| Newsgroups | org.kernel.vger.linux-sh,org.kernel.vger.linux-gpio,org.kernel.vger.linux-input,org.kernel.vger.linux-kernel,org.kernel.vger.linux-leds |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 10 Jul 2026, Arnd Bergmann wrote: > From: Arnd Bergmann <[email protected]> > > There are still a handful of ancient mips/armv5/sh boards that use the > gpio_led:gpio member to pass an old-style gpio number, but all modern > users have been converted to gpio descriptors. > > While the CONFIG_GPIOLIB_LEGACY option that guards devm_gpio_request_one() > and related helpers is currently turned on in all kernel builds, > the plan is to only enable it on the few platforms that actually > pass gpio numbers in any platform_data. > > Split out the legacy portion of the platform_data handling into a custom > helper function that is guarded with in #ifdef block, to allow the > the leds-gpio driver to compile cleanly when CONFIG_GPIOLIB_LEGACY > gets turned off. Once the last user is converted, this function can > be removed. > > Link: https://lore.kernel.org/all/[email protected]/ > Reviewed-by: Linus Walleij <[email protected]> > Reviewed-by: Bartosz Golaszewski <[email protected]> > Reviewed-by: Andy Shevchenko <[email protected]> > Acked-by: Dmitry Torokhov <[email protected]> # for input > Signed-off-by: Arnd Bergmann <[email protected]> > --- > v5: no changes > v4: whitespace changes only > v3: simplify gpio_led_get_gpiod > v2: rework a little bit to keep the legacy code path more separate, > extend changelog description > --- > drivers/leds/leds-gpio.c | 52 +++++++++++++++++++++++++++------------- > include/linux/leds.h | 2 ++ > 2 files changed, 37 insertions(+), 17 deletions(-) Any deps? -- Lee Jones