Re: [PATCH] sh: remove unused setup_profiling_timer function

Geert Uytterhoeven <[email protected]>
Newsgroups org.kernel.vger.linux-sh,org.kernel.vger.linux-kernel
Message-ID <CAMuHMdXT44zxeNmNZeufKxUWz3_iYPqAY7Nu6g8eL4EBx1grnw@mail.gmail.com>
Hi Adrian,

On Fri, 21 Aug 2026 at 14:11, John Paul Adrian Glaubitz
<[email protected]> wrote:
> On Thu, 2026-08-20 at 14:39 +0200, Anthony Iliopoulos wrote:
> > setup_profiling_timer() is not used by any code at this point. Since a
> > default weak implementation exists, there is no need to keep this
> > arch-specific definition around. Remove it along with the now-redundant
> > profile header includes.
>
> Do you have any clue why it was still implemented for LoongArch which is
> a rather new architecture? I'm also seeing that it's not used anywhere,
> I'm just wondering why it was not removed before and why it was even
> included when LoongArch was added.

To make it _succeed_ when writing an integer value to that file?
The default weak implementation returns an error code.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.