Re: ASoC: tas2783-sdw: calibration firmware not re-downloaded after s2idle resume (AMD ACP SoundWire, ASUS ProArt PX13)

Mark Brown <[email protected]>
Newsgroups org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Mon, Jul 27, 2026 at 11:13:29AM +0300, Andrey Golovko wrote:

> What does work here: drop the stale cache instead of syncing it, i.e.
> regcache_drop_region(0, UINT_MAX) before tas_io_init() when the device
> re-attaches uninitialized, so the following update_bits() calls read real
> hardware. Side effect: user-set controls fall back to hardware defaults
> after a resume, which seems the lesser evil versus a silent amp.

That's buggy since it will throw away all the userspace configuration
done through controls that map directly onto registers, without
notifications too.  The suspend path should be bringing the driver down
to idle and then that should be undone on resume.
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmpnYKUACgkQJNaLcl1U
h9DRNwf9FGNDYbfx/26uKOy1N+3efj0P09ytTearbgakY85kVdn+CSKt5F/lQ4pw
in7GYlWeb/loeN3yt1a1gQZWwVGQjEoa0ScMOiTg1+vb/gqOAILyiEBzehRN/rV7
C9zguyH6vtCAjR/PoJv/CHleusj/U67lweiUwgZ7X+ijCao573Vjuuq8D7wMBWT+
ylH/+v8iwMJT9yybExdbH18uUx6Hikx7+pBTqfFUNEb7yXSmIq2N0oEN5bItR9QU
9awCRo4vqtrxJlEXupJZvtDgbvolIl5xOnRIe9RJKFedfbDpt0cBkhqMlW7usJHQ
gnKGIgOUaSf9aja/16zMi++vCV7Ytw==
=EB8Q
-----END PGP SIGNATURE-----
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.