Re: [PATCH v8 1/3] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Document DAI subnode
Ajay Kumar Nandam <[email protected]>
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/28/2026 1:39 AM, Krzysztof Kozlowski wrote: > On Mon, Jul 27, 2026 at 08:57:52PM +0530, Ajay Kumar Nandam wrote: >> >> >> On 7/27/2026 8:42 PM, Mohammad Rafi Shaik wrote: >>> Extend the qcom,q6apm-lpass-dais device tree binding to explicitly >>> describe Digital Audio Interface (DAI) child nodes. >>> >>> Add #address-cells and #size-cells to allow representation of multiple >>> DAI instances as child nodes, and define a dai@<id> pattern to document >>> per-DAI properties such as the interface ID and associated clocks. >>> >>> On platforms such as Monaco and Lemans, third-party codecs are hardware >>> wired to the SoC and do not always have an in-tree codec driver to manage >>> their clocks. For these designs, clock line enablement must be driven >>> from the platform side, and this series provides the necessary support >>> for that. >>> >>> On QAIF-based platforms such as Shikra and Hawi, responsibility for voting >>> I2S MCLK and BCLK has moved from the DSP to the kernel. This series >>> introduces the required device tree binding support to represent and >>> vote for these clocks from the kernel. >>> >>> Co-developed-by: Srinivas Kandagatla <[email protected]> >>> Signed-off-by: Srinivas Kandagatla <[email protected]> >>> Reviewed-by: Krzysztof Kozlowski <[email protected]> >>> Signed-off-by: Mohammad Rafi Shaik <[email protected]> >>> --- >>> .../bindings/sound/qcom,q6apm-lpass-dais.yaml | 50 +++++++++++++++++++ >>> 1 file changed, 50 insertions(+) >>> >> >> Thanks for the patch. >> >> Tested on Shikra-IQS. No issues observed. >> >> Tested-by: Ajay Kumar Nandam <[email protected]> > > No, please drop. You could not test this patch on Shikra-IQS. It's > impossible. > > Otherwise please provide steps which execute this code on the target > device. Hi Krzysztof, You are right. The Tested-by tag was added here by mistake. I validated the complete series on Shikra-IQS and later provided the Tested-by on the cover letter instead. Please drop my Tested-by tag from this patch. Thanks for the correction. Best regards, Ajay kumar Nandam > > Best regards, > Krzysztof >