Re: [PATCH 1/2] ASoC: sprd: sprd-mcdt: Drop redundant error messages

Baolin Wang <[email protected]>
Newsgroups org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel
Message-ID <[email protected]>

On 7/29/26 3:35 PM, [email protected] wrote:
> From: bui duc phuc <[email protected]>
> 
> The called functions already log failures where appropriate. Return the
> original error directly and avoid duplicate error messages.
> 
> Signed-off-by: bui duc phuc <[email protected]>
> ---

LGTM.
Reviewed-by: Baolin Wang <[email protected]>

>   sound/soc/sprd/sprd-mcdt.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/sound/soc/sprd/sprd-mcdt.c b/sound/soc/sprd/sprd-mcdt.c
> index 5f3a2a7bce31..d9a7bbd6c0b6 100644
> --- a/sound/soc/sprd/sprd-mcdt.c
> +++ b/sound/soc/sprd/sprd-mcdt.c
> @@ -931,10 +931,8 @@ static int sprd_mcdt_probe(struct platform_device *pdev)
>   
>   	ret = devm_request_irq(&pdev->dev, irq, sprd_mcdt_irq_handler,
>   			       0, "sprd-mcdt", mcdt);
> -	if (ret) {
> -		dev_err(&pdev->dev, "Failed to request MCDT IRQ\n");
> +	if (ret)
>   		return ret;
> -	}
>   
>   	sprd_mcdt_init_chans(mcdt, res);
>
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.