RE: [PATCH] ASoC: rt722: reset codec to fix abnormal sound

Shuming [范書銘] <[email protected]>
Newsgroups org.kernel.vger.linux-sound
Message-ID <[email protected]>
> > The audio output may become abnormal after a warm reboot from
> Windows.
> > Reset the codec once during hardware initialization to restore it to a
> > known state and prevent the issue.
> 
> > @@ -1888,6 +1899,9 @@ int rt722_sdca_io_init(struct device *dev, struct
> sdw_slave *slave)
> >  	rt722->hw_vid = (val & 0x0f00) >> 8;
> >  	dev_dbg(&slave->dev, "%s hw_vid=0x%x\n", __func__, rt722->hw_vid);
> >
> > +	if (!rt722->first_hw_init)
> > +		rt722_sdca_reset(rt722);
> > +
> >  	rt722_sdca_dmic_preset(rt722);
> >  	rt722_sdca_amp_preset(rt722);
> >  	rt722_sdca_jack_preset(rt722);
> 
> Slirhgly separate issue but you probably need a _jack_init() after the reset -
> your other devices do that, I think there's some races there.

Understood. I'll add _jack_init() after the reset to avoid its settings being reset by the reset.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.