Re: [PATCH] ASoC/soundwire: Intel: reset the PCMSyCM registers in hda_sdw_bpt_close
Pierre-Louis Bossart <[email protected]>
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
On 7/30/26 03:25, Bard Liao wrote: > Resetting the PCMSyCM registers is required for Intel SoundWire stream. The > same procedure is done in sdw_hda_dai_hw_params() for the normal it's actually in sdw_hda_dai_hw_free() for the regular cases, the sequence is also used in hw_params() but for corner cases such as xruns/drops, see comment: /* * reset the PCMSyCM registers to handle a prepare callback when the PCM is restarted * due to xruns or after a call to snd_pcm_drain/drop() */ No need to respin the patch for this nit-pick. > SoundWire stream, too. > > Signed-off-by: Bard Liao <[email protected]> > Reviewed-by: Péter Ujfalusi <[email protected]> > Reviewed-by: Liam Girdwood <[email protected]> LGTM, this patch makes the _close() sequence and api mimic the _open() one. Reviewed-by: Pierre-Louis Bossart <[email protected]>