Re: [PATCH] ASoC: cs42xx8: fix regmap SPI flag masks to target high byte

Mark Brown <[email protected]> Thu, 30 Jul 2026 16:57:48 +0100
Newsgroups org.kernel.vger.linux-sound,org.kernel.vger.linux-kernel
Message-ID <[email protected]>
On Fri, Jul 24, 2026 at 06:31:28PM +0530, [email protected] wrote:

>  	config.reg_bits           = 16;
> -	config.write_flag_mask    = 0x9E;
> -	config.read_flag_mask     = 0x9F;
> +	config.write_flag_mask    = 0x9E00;
> +	config.read_flag_mask     = 0x9F00;

Have you tested this or did you do this purely by inspection?  I'm a bit
concerned about how well the regmap core deals with the endianness
issues for multi-byte masks here.
signature.asc (application/pgp-signature, 488 B)
-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmprdHsACgkQJNaLcl1U
h9Cm5Qf/XMYFKkE+FFELIQ9zJKg8NAkPTZbYMNqT7qGZJE/4DhIbLRyaiDHs/giL
nKEvanVcBkh310AncgcmN0H2ZuaZngYmvQ80GdEIfAOd54y7lXvwe0M/uDnAgnxT
WoudrAtTHjkyIU2ks84TK5J9TGzOmPMsOQGtr9FQWNjJ3A+hEkiH3l45Z5yXxwit
lhAFzKCu3hseDYjF/ZgzuJ/3rr/ij4KJKU2DS75xb/9JjPHwem6iP7MeeRzDQGuY
EAtjStxH5Ht4Nf1Z6i+6izVpmWetg7t98Thez/pXz8EAOOVSOfMeOOpG/YxJzvYb
Pp03L3Hj0i1Lt5KOXBMbhhmxyV+CoA==
=0U8n
-----END PGP SIGNATURE-----