Re: [PATCH v6 09/15] ASoC: qdsp6: q6routing: add lpi mi2s support

On 7/30/26 6:43 PM, Richard Acayan wrote:
> Add the ASM-AFE routing for LPI MI2S ports which represent internal MI2S
> ports on SDM660.
> 
> Signed-off-by: Richard Acayan <[email protected]>
> ---

Reviewed-by: Srinivas Kandagatla <[email protected]>

--srini
>  sound/soc/qcom/qdsp6/q6routing.c | 78 +++++++++++++++++++++++++++++++-
>  1 file changed, 77 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
> index 7386226046fa..d076c99f197f 100644
> --- a/sound/soc/qcom/qdsp6/q6routing.c
> +++ b/sound/soc/qcom/qdsp6/q6routing.c
> @@ -127,7 +127,14 @@
>  	{ mix_name, "TX_CODEC_DMA_TX_2", "TX_CODEC_DMA_TX_2"},	\
>  	{ mix_name, "TX_CODEC_DMA_TX_3", "TX_CODEC_DMA_TX_3"},	\
>  	{ mix_name, "TX_CODEC_DMA_TX_4", "TX_CODEC_DMA_TX_4"},	\
> -	{ mix_name, "TX_CODEC_DMA_TX_5", "TX_CODEC_DMA_TX_5"}
> +	{ mix_name, "TX_CODEC_DMA_TX_5", "TX_CODEC_DMA_TX_5"},	\
> +	{ mix_name, "LPI_MI2S_TX_0", "LPI_MI2S_TX_0" },		\
> +	{ mix_name, "LPI_MI2S_TX_1", "LPI_MI2S_TX_1" },		\
> +	{ mix_name, "LPI_MI2S_TX_2", "LPI_MI2S_TX_2" },		\
> +	{ mix_name, "LPI_MI2S_TX_3", "LPI_MI2S_TX_3" },		\
> +	{ mix_name, "LPI_MI2S_TX_4", "LPI_MI2S_TX_4" },		\
> +	{ mix_name, "LPI_MI2S_TX_5", "LPI_MI2S_TX_5" },		\
> +	{ mix_name, "LPI_MI2S_TX_6", "LPI_MI2S_TX_6" }
>  
>  #define Q6ROUTING_TX_MIXERS(id)						\
>  	SOC_SINGLE_EXT("PRI_MI2S_TX", PRIMARY_MI2S_TX,			\
> @@ -320,6 +327,27 @@
>  		id, 1, 0, msm_routing_get_audio_mixer,			\
>  		msm_routing_put_audio_mixer),				\
>  	SOC_SINGLE_EXT("TX_CODEC_DMA_TX_5", TX_CODEC_DMA_TX_5,		\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_0", LPI_MI2S_TX_0,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_1", LPI_MI2S_TX_1,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_2", LPI_MI2S_TX_2,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_3", LPI_MI2S_TX_3,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_4", LPI_MI2S_TX_4,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_5", LPI_MI2S_TX_5,			\
> +		id, 1, 0, msm_routing_get_audio_mixer,			\
> +		msm_routing_put_audio_mixer),				\
> +	SOC_SINGLE_EXT("LPI_MI2S_TX_6", LPI_MI2S_TX_6,			\
>  		id, 1, 0, msm_routing_get_audio_mixer,			\
>  		msm_routing_put_audio_mixer),
>  
> @@ -709,6 +737,26 @@ static const struct snd_kcontrol_new rxcodec_dma_rx_6_mixer_controls[] = {
>  static const struct snd_kcontrol_new rx_codec_dma_rx_7_mixer_controls[] = {
>  	Q6ROUTING_RX_MIXERS(RX_CODEC_DMA_RX_7) };
>  
> +static const struct snd_kcontrol_new lpi_mi2s_rx_0_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_0) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_1_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_1) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_2_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_2) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_3_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_3) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_4_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_4) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_5_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_5) };
> +
> +static const struct snd_kcontrol_new lpi_mi2s_rx_6_mixer_controls[] = {
> +	Q6ROUTING_RX_MIXERS(LPI_MI2S_RX_6) };
>  
>  static const struct snd_kcontrol_new mmul1_mixer_controls[] = {
>  	Q6ROUTING_TX_MIXERS(MSM_FRONTEND_DAI_MULTIMEDIA1) };
> @@ -938,6 +986,27 @@ static const struct snd_soc_dapm_widget msm_qdsp6_widgets[] = {
>  	SND_SOC_DAPM_MIXER("USB_RX Audio Mixer", SND_SOC_NOPM, 0, 0,
>  			   usb_rx_mixer_controls,
>  			   ARRAY_SIZE(usb_rx_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_0 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_0_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_0_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_1 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_1_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_1_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_2 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_2_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_2_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_3 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_3_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_3_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_4 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_4_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_4_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_5 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_5_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_5_mixer_controls)),
> +	SND_SOC_DAPM_MIXER("LPI_MI2S_RX_6 Audio Mixer", SND_SOC_NOPM, 0, 0,
> +		lpi_mi2s_rx_6_mixer_controls,
> +		ARRAY_SIZE(lpi_mi2s_rx_6_mixer_controls)),
>  	SND_SOC_DAPM_MIXER("MultiMedia1 Mixer", SND_SOC_NOPM, 0, 0,
>  		mmul1_mixer_controls, ARRAY_SIZE(mmul1_mixer_controls)),
>  	SND_SOC_DAPM_MIXER("MultiMedia2 Mixer", SND_SOC_NOPM, 0, 0,
> @@ -1031,6 +1100,13 @@ static const struct snd_soc_dapm_route intercon[] = {
>  	Q6ROUTING_RX_DAPM_ROUTE("RX_CODEC_DMA_RX_6 Audio Mixer", "RX_CODEC_DMA_RX_6"),
>  	Q6ROUTING_RX_DAPM_ROUTE("RX_CODEC_DMA_RX_7 Audio Mixer", "RX_CODEC_DMA_RX_7"),
>  	Q6ROUTING_RX_DAPM_ROUTE("USB_RX Audio Mixer", "USB_RX"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_0 Audio Mixer", "LPI_MI2S_RX_0"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_1 Audio Mixer", "LPI_MI2S_RX_1"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_2 Audio Mixer", "LPI_MI2S_RX_2"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_3 Audio Mixer", "LPI_MI2S_RX_3"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_4 Audio Mixer", "LPI_MI2S_RX_4"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_5 Audio Mixer", "LPI_MI2S_RX_5"),
> +	Q6ROUTING_RX_DAPM_ROUTE("LPI_MI2S_RX_6 Audio Mixer", "LPI_MI2S_RX_6"),
>  	Q6ROUTING_TX_DAPM_ROUTE("MultiMedia1 Mixer"),
>  	Q6ROUTING_TX_DAPM_ROUTE("MultiMedia2 Mixer"),
>  	Q6ROUTING_TX_DAPM_ROUTE("MultiMedia3 Mixer"),