Re: [PATCH 4/6] ASoC: SOF: ipc4-topology: Add payload to pipeline create messages

Mark Brown <[email protected]> Fri, 31 Jul 2026 00:37:00 +0100

Newsgroups	org.kernel.vger.linux-sound
Message-ID	<[email protected]>

On Thu, Jul 30, 2026 at 01:41:39PM +0300, Peter Ujfalusi wrote:

> +	/*
> +	 * If this is not a Data Processing module instance, add the
> +	 * required heap sizes to the sum of all module instances belonging
> +	 * to the same pipeline, and find the maximum stack requirement
> +	 * among all module instances belonging to the same pipeline.
> +	 */
> +	if (swidget->comp_domain != SOF_COMP_DOMAIN_DP) {

Does this DTRT if the comp_domain was read from the manifest?

> +static void sof_ipc4_widget_pipe_ext_obj_memory_data(struct snd_sof_dev *sdev,
> +						     struct snd_sof_widget *swidget,
> +						     u32 *payload, u32 *ext_pos,
> +						     struct sof_ipc4_glb_pipe_ext_object **hdr)
> +{

> +	mem_data->domain_id = swidget->domain_id;

Do we need SOF_COMP_EXT_TOKENS in pipeline_token_list to parse the
domain ID?

signature.asc (application/pgp-signature, 488 B)