Re: [PATCH 4/6] ASoC: SOF: ipc4-topology: Add payload to pipeline create messages

On Fri, 2026-07-31 at 00:37 +0100, Mark Brown wrote:
> On Thu, Jul 30, 2026 at 01:41:39PM +0300, Peter Ujfalusi wrote:
> 
> > +	/*
> > +	 * If this is not a Data Processing module instance, add
> > the
> > +	 * required heap sizes to the sum of all module instances
> > belonging
> > +	 * to the same pipeline, and find the maximum stack
> > requirement
> > +	 * among all module instances belonging to the same
> > pipeline.
> > +	 */
> > +	if (swidget->comp_domain != SOF_COMP_DOMAIN_DP) {
> 
> Does this DTRT if the comp_domain was read from the manifest?
> 

Linux driver does not do that, but the SOF FW is supposed to, and it
will give an IPC error if the module cannot be configured as a DP
module. E.g. the topology should be compatible with the firmware build,
and if it's not, there is nothing the Linux driver can do about it but
fail.

> > +static void sof_ipc4_widget_pipe_ext_obj_memory_data(struct
> > snd_sof_dev *sdev,
> > +						     struct
> > snd_sof_widget *swidget,
> > +						     u32 *payload,
> > u32 *ext_pos,
> > +						     struct
> > sof_ipc4_glb_pipe_ext_object **hdr)
> > +{
> 
> > +	mem_data->domain_id = swidget->domain_id;
> 
> Do we need SOF_COMP_EXT_TOKENS in pipeline_token_list to parse the
> domain ID?

Not for the moment. We could indeed add its parsing to pipeline nodes,
but for the moment the domain_id IPC field in the pipeline message is
for future use, and the default 0 for the default memory domain is all
we need for the pipelines ATM. The FW is not yet, or in the near
future, ready to assign different memory domains for different
pipelines.

Best regards,
Jyri