Re: [PATCH v3 11/26] ASoC: codecs: wcd-mbhc: Use guard() for mutex locks

Mark Brown <[email protected]> Fri, 31 Jul 2026 16:29:24 +0100

Newsgroups	org.kernel.vger.linux-sound,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-kernel
Message-ID	<[email protected]>

On Fri, Jul 31, 2026 at 10:06:33AM +0700, [email protected] wrote:

> @@ -419,9 +420,8 @@ static void wcd_cancel_hs_detect_plug(struct wcd_mbhc *mbhc,
>  				      struct work_struct *work)
>  {
>  	mbhc->hs_detect_work_stop = true;
> -	mutex_unlock(&mbhc->lock);
> +	guard(mutex)(&mbhc->lock);
>  	cancel_work_sync(work);
> -	mutex_lock(&mbhc->lock);
>  }
>  
This replacing dropping a lock with taking a lock which will both take
the lock twice and deadlock.

signature.asc (application/pgp-signature, 488 B)