Re: [PATCH 1/2] ALSA: hda/realtek: Limit Star Labs internal mic boost

Hi Sean,

On 8/1/26 4:13 AM, Sean Rhodes wrote:
> The 30 dB internal mic boost is too high for laptops, especially with fans. Limit Star Labs internal mic boost to 10 dB.
> 
> Signed-off-by: Sean Rhodes <[email protected]>
> ---
>  sound/hda/codecs/realtek/alc269.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 379e1458f4ac..42756a3f3f8e 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -4188,6 +4188,7 @@ enum {
>  	ALC245_FIXUP_CLEVO_NOISY_MIC,
>  	ALC269_FIXUP_VAIO_VJFH52_MIC_NO_PRESENCE,
>  	ALC233_FIXUP_MEDION_MTL_SPK,
> +	ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST,
>  	ALC233_FIXUP_STARLABS_STARFIGHTER,
>  	ALC294_FIXUP_BASS_SPEAKER_15,
>  	ALC283_FIXUP_DELL_HP_RESUME,
> @@ -6725,6 +6726,10 @@ static const struct hda_fixup alc269_fixups[] = {
>  			{ }
>  		},
>  	},
> +	[ALC269_FIXUP_STARLABS_LIMIT_INT_MIC_BOOST] = {
> +		.type = HDA_FIXUP_FUNC,
> +		.v.func = alc269_fixup_limit_int_mic_boost,
> +	},

I guess the reason you're creating a new quirk is because the existing
ALC269_FIXUP_LIMIT_INT_MIC_BOOST is chained to ALC269_FIXUP_THINKPAD_ACPI.
This makes the quirk identical to ALC269_FIXUP_THINKPAD_ACPI. Would it be
worth reworking the existing ALC_269_FIXUP_LIMIT_INT_MIC_BOOST to not be
chained and then create a new ALC269_FIXUP_THINKPAD_LIMIT (or similar) for
whichever devices that need it?

--
Regards,
  Eric