Re: [PATCH 02/44] ASoC: codecs: ad1*: use .auto_selectable_formats

On Tue, Aug 04, 2026 at 12:40:36AM +0000, Kuninori Morimoto wrote:
> We can use .auto_selectable_formats. Let's adds it.
> 
> Signed-off-by: Kuninori Morimoto <[email protected]>
> ---

Acked-by: Nuno Sá <[email protected]>

>  sound/soc/codecs/ad1836.c |  6 ++++++
>  sound/soc/codecs/ad193x.c | 10 ++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/sound/soc/codecs/ad1836.c b/sound/soc/codecs/ad1836.c
> index 8afeadcaf8b09..dbea83bd49b69 100644
> --- a/sound/soc/codecs/ad1836.c
> +++ b/sound/soc/codecs/ad1836.c
> @@ -193,9 +193,15 @@ static int ad1836_hw_params(struct snd_pcm_substream *substream,
>  	return 0;
>  }
>  
> +static const u64 ad1836_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops ad1836_dai_ops = {
>  	.hw_params = ad1836_hw_params,
>  	.set_fmt = ad1836_set_dai_fmt,
> +	.auto_selectable_formats = &ad1836_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>  };
>  
>  #define AD183X_DAI(_name, num_dacs, num_adcs) \
> diff --git a/sound/soc/codecs/ad193x.c b/sound/soc/codecs/ad193x.c
> index b93531c3a9a40..9841c779b1752 100644
> --- a/sound/soc/codecs/ad193x.c
> +++ b/sound/soc/codecs/ad193x.c
> @@ -394,6 +394,14 @@ static int ad193x_startup(struct snd_pcm_substream *substream,
>  				   &constr);
>  }
>  
> +static const u64 ad193x_selectable_formats =
> +	SND_SOC_POSSIBLE_DAIFMT_I2S	|
> +	SND_SOC_POSSIBLE_DAIFMT_DSP_A	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_NB_IF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_NF	|
> +	SND_SOC_POSSIBLE_DAIFMT_IB_IF;
> +
>  static const struct snd_soc_dai_ops ad193x_dai_ops = {
>  	.startup = ad193x_startup,
>  	.hw_params = ad193x_hw_params,
> @@ -401,6 +409,8 @@ static const struct snd_soc_dai_ops ad193x_dai_ops = {
>  	.set_tdm_slot = ad193x_set_tdm_slot,
>  	.set_sysclk	= ad193x_set_dai_sysclk,
>  	.set_fmt = ad193x_set_dai_fmt,
> +	.auto_selectable_formats = &ad193x_selectable_formats,
> +	.num_auto_selectable_formats = 1,
>  	.no_capture_mute = 1,
>  };
>  
> -- 
> 2.53.0
>