Re: [PATCH v2 2/4] ASoC: renesas: enable COMPILE_TEST for PCM SH7760

Hi Geert, Mark

> > 1. "depends on SH_DMABRG" should be fine, as SH_DMABRG is a
> >     user-visible symbol,
> > 2. SH_DMABRG depends on CPU_SUBTYPE_SH7760, so you cannot just select
> >     it without enabling compile-testing for SH_DMABRG first.
> 
> Do we need to use "depends" for it ?
> 
> SH_DMABRG is indeed defined as user-visible, but is needed only for Sound
> (and/or USB ?). It is specific/necessary feature, not generic feature.
> 
> In this case, it should be selected automatically if Sound (and/or USB) was
> selected, IMO. In such case, we can compile with COMPILE_TEST ?

Self-correction
we can't use "select" for SH_DMABRG...

Hmm.. we can't use COMPILE_TEST for this, and no defconfig is selecting this.
I guess no one is using it. Can we remove them, like ssi.c (= [4/4]) ?
This kind of driver that leaks from compile test and/or it is thought as
no one is using is very difficult to keep compatible...
Whenever we can get-back it because we are using git.

Thank you for your help !!

Best regards
---
Kuninori Morimoto