Re: [PATCH 0/3] ASoC: cs35l41/cs35l45/cs4265: sort the reg_defaults tables
Péter Ujfalusi <[email protected]> Wed, 5 Aug 2026 12:25:32 +0300
| Newsgroups | org.kernel.vger.linux-sound,org.kernel.vger.stable |
|---|---|
| Message-ID | <[email protected]> |
On 05/08/2026 12:00, Richard Fitzgerald wrote: >> Wow. Would it make sense to have a regmap helper to double-check the >> addresses are indeed in-order in those reg_default tables? >> I am not sure how this requirement can be enforced by just inspection, a >> warning would help detect this sort of issues on more platforms. >> > It does seem probable that anything that relies on people just > remembering to keep a large table sorted is prone to breaking, > especially if the addresses are provided by named constant instead of > a list of hardcoded numbers. We have seen these 'soundwire_intel.link.0: Msg ignored for Slave 6' type off messages in random cases, but with a series which check the regcache_sync return value some codec's resume started to fail. "*: Propagate regcache_sync() errors" So, yes, register values generated by magic macros are hard to keep in order, I completely agree. -- Péter