Re: [PATCH 0/3] ASoC: cs35l41/cs35l45/cs4265: sort the reg_defaults tables

Péter Ujfalusi <[email protected]> Wed, 5 Aug 2026 13:17:52 +0300
Newsgroups org.kernel.vger.linux-sound,org.kernel.vger.stable
Message-ID <[email protected]>

On 05/08/2026 13:10, Charles Keepax wrote:
>>> I don't think we need to sort them. Just fail, so that an unsorted table
>>> must be fixed.
>>
>> That would be a big regression all around the place, ordering w/ the
>> debug message if developer is interested is much better.
> 
> I think I would come down between the two of you. I definitely
> agree with Richard on don't sort them, just encourages drivers to
> be wrong. But I also agree with you, don't hard fail. I would
> vote for just print an error message and carry on. That way no
> regressions, but also a nice big warning message to let people
> know what is wrong when they see problems.

I usually try to avoid alarming/annoying users with error messages, on
the other hand I agree that w/o some pressure, these will never be
corrected at root either ;)

On the yet another hand, if the regcache have means to fix this, it
might be put into use as well.
A dev_warn at max to get attention or info level perhaps and fixing it up?

-- 
Péter